[PATCH] Small bug in grxprint.c

30 Oct 2003

valgrind showed a small bug in addons/grxprint.c which causes reading
1 byte directly before allocated memory due to wrong order of conditions
in while loop. Perhaps it's rather harmless, but should be fixed anyway. 

Andris

--- grx246/addons/print/grxprint.c~2	2002-02-11 00:27:30.000000000 +0200
+++ grx246/addons/print/grxprint.c	2003-10-30 20:18:53.000000000 +0200
@@ -980,7 +980,7 @@ void  LaserPrint ( struct _DST * DSTPtr 
 
 	     S = Buf + RowBytes;
 	     FullCount = RowBytes;
-	     while (*(--S)==0 && FullCount>0) FullCount--;
+	     while (FullCount>0 && *(--S)==0) FullCount--;
 
 	     /* Versuchen die Zeile nach Algorithmus 2 (TIFF Pacbits) zu    */
 	     /* komprimieren. Abgeschickt wird dann der kuerzere der beiden */

    

[PATCH] Small bug in grxprint.c

Andris Pavenis