Frank Heckenbach escribió:
Hi again,
first I've added `const' (C) and `protected' (Pascal) to some function parameters, to make them a little "safer" (diff19 -- also contains some other small corrections).
Ok, I will need some time to validate it, it's a big patch (and a good work :-)
Then I compared graph.pas with Borland's version and noticed (only) the following incompatibilities, some of which are easy to fix (diff20):
Ok
....
Anyway, it seems inconsistent to me that White is a function which returns the correct value and the other colors are constants which contain (in general) wrong values. So, what is more important -- that the colors behave as their name says, or that they are constants (and can be used in initializers) with values compatible to BP and to other units (like CRT)? I think the former, so I'm adding the functions (but in a separate patch, diff21, in case you disagree; in that case I'd also suggest making White a constant with value 15).
It's ok for me (I don't know Pascal), any comments Maurice?
Finally, pascal/bgi/demo.pas mentions some "unknown crashes with GPC". I can't reproduce them (without the "work-around"), neither on Linux nor DJGPP. Does anyone know more about them, or were they perhaps with older versions only? In this case, I'd suggest to remove the note and the "work-around". (diff22)
Again, it's ok for me