Hi Mariano and Alex,
I've been looking at the bug reported by Alex in the function GrBitBlt1bpp. I believe that the patch proposed by Alex is completely right. Sorry for the delay, but this has taken some mental rewind :-)
I'm happy to see that Grx continues growing and getting better, and hope to contribute again in the future.
Regards
Josu Onandia
-----Mensaje original----- De: Mariano Alvarez Fernandez [SMTP:malfer@telefonica.net] Enviado el: martes 22 de octubre de 2002 22:15 Para: alexbodn@012.net.il CC: grx@gnu.de Asunto: Re: small bugfixes in grx
Hi, Alex.
About the drawstrg bug.
It isn't (and if it were a bug the correct place to check is in the
fdriver, because it must know how to get the color from a GrColor variable).
The problem is in the test program. GrAllocEgaColors must be placed_after_ GrSetMode.
About the bitblt1 bug.
Yes, thanks, I now see the bug. I will apply your patch:
--- bitblt1b.old Sat Apr 14 03:56:00 2001 +++ bitblt1b.c Tue Oct 22 21:43:58 2002 @@ -50,7 +50,9 @@
(dst->gc_driver->drawbitmap)((dx + dst->gc_xoffset),(dy + dst->gc_yoffset), (x2 - x1 + 1),(y2 - y1 + 1),src->gc_baseaddr[0],src->gc_lineoffset,
- ((dx - oldx1) + ((dy - oldy1) * (src->gc_lineoffset << 3))),fg,bg);
- /*alex:the offset should anyway be the x1,y1 point in src, as
clipped*/
- (x1 + (y1 * ((dx - oldx1) + ((dy - oldy1) * (src->gc_lineoffset <<
3))),
fg,bg);
mouse_unblock();
}
(Are you here Josu?, do you think is ok?)
About the 1024*768*4bpp problem
I can't reproduce it in none of my PC's, they all work well. Have
you checked the modetest program?. What about if you set GRX20DRV=VESA?
Thanks a lot for your work Alex.
Regards, M.Alvarez
-
Josu Onandia