Gpc October 2007

gpc@gnu.de

6 participants
13 discussions

Inefficiency of `mod'
by Emil Jerabek 25 Oct '10

25 Oct '10

Hi, during some debugging I noticed that GPC generates very hairy code for the `mod' operator with signed arguments. A closer look revealed that the code contains a lot of branching on conditions which can be determined on compile time, and most surprisingly, the value of X mod Y is recomputed _twice_, if X is negative. (I've attached a commented assembler dump.) This may be partially a back-end problem (CSE?), but I feel there's something wrong in the relevant code in gpc-common.c (build_pascal_binary_op) as well. `exp1 mod exp2' gets translated into something like exp2 <= 0 ? error : exp1 >= 0 ? exp1 mod exp2 : ((-exp1) mod exp2) == 0 ? 0 : exp2 - (-exp1) mod exp2 This arranges that both arguments supplied to the "internal mod" are non-negative, but this information is not passed on -- the arguments are still declared as signed types, which apparently makes the back-end to produce the mess it does. I've done a little test: the following replacement for `mod', which differs from the built-in one essentially just by the type-casts to `Cardinal', inline operator xmod (X, Y: Integer) = Z: Integer; begin if Y <= 0 then RuntimeError (714); if X >= 0 then Z := Cardinal (X) mod Y else begin Z := Cardinal (-X) mod Y; if Z <> 0 then Z := Y - Z end end; indeed generates a better code, it measures about 15% faster for positive X and more than twice faster for negative X. YMMV. If this is possible in user code, it should work in the compiler internals as well :) The result type of the whole `mod' expression looks dubious too. IIUIC, `exp1 mod exp2' inherits the type of exp1. Now, the result of `mod' is guaranteed to be nonnegative and to fit in the type of exp2 (or more precisely, it is in 0 .. High (type of (exp2)) - 1), whereas it needn't have anything to do with the type of exp1: consider var X, Z: Integer; Y: LongInt; begin X := -8; Y := High (LongInt); Z := X mod Y { -> overflow } end Or am I missing something? Emil (BTW, where is fjf434c.pas?)

10 16

New (gpc-20060325)
by Waldek Hebisch 08 Dec '09

08 Dec '09

I have put a new gpc snapshot at: http://www.math.uni.wroc.pl/~hebisch/gpc-20060325.tar.bz2 Main change is preliminary gcc-4.0.x support. The other changes are rather small. Note that for "production use" 3.4.x and 3.3.x backend are prefered. Also, using 2.8.1, 2.95.3 and 3.2.3 backend should work, but is depreciated. For more detail see: http://www.math.uni.wroc.pl/~hebisch/gpc/NEWS-20060325 and http://www.math.uni.wroc.pl/~hebisch/gpc/Fixed-20060325 -- Waldek Hebisch hebisch(a)math.uni.wroc.pl

7 44

compiling static library + gpc runtime without _statvfs on Mac OS X for Intel
by Glenn Howes 20 Apr '08

20 Apr '08

Hello, After months of being distracted by another portion of my application, I'm back to creating a universal binary version of the Pascal based library we are linking into our C++ based application. The problem is the application will not launch under PPC on Mac OS X 10.3 (Panther). The console registers an undefined symbol: _statvfs expected to be defined in /usr/lib/libSystem.B.dylib After some research, I found this call is being used by the StatFS routine implemented in rts.c (line 1510) /** Get information about a file system. */ GLOBAL (Boolean _p_StatFS (char *Path UNUSED, StatFSBuffer *Buf)) { int Result; #ifdef HAVE_STATVFS struct statvfs b; errno = 0; Result = statvfs (Path, &b); Buf->BlockSize = (long long int) b.f_frsize; Buf->BlocksTotal = (long long int) b.f_blocks; Buf->BlocksFree = (long long int) b.f_bavail; Buf->FilesTotal = (int) b.f_files; Buf->FilesFree = (int) b.f_favail; #elif defined (HAVE_STATFS) struct statfs b; errno = 0; Result = statfs (Path, &b); Buf->BlockSize = (long long int) b.f_bsize; Buf->BlocksTotal = (long long int) b.f_blocks; Buf->BlocksFree = (long long int) b.f_bavail; Buf->FilesTotal = (int) b.f_files; Buf->FilesFree = (int) b.f_ffree; #else Result = -1; errno = ENOSYS; #endif if (Result == 0) return True; Buf->BlockSize = 0; Buf->BlocksTotal = 0; Buf->BlocksFree = 0; Buf->FilesTotal = 0; Buf->FilesFree = 0; return False; } It appears to me that HAVE_STATVFS is defined if my current OS X SDK (10.4) has a statvfs.h header file amongst its include files, which means if I build my Pascal development environment from the build-on- Intel.command that the statvfs version will be hard wired into the runtime and any binary I generate will not work on 10.3 (which does not have statvfs in its libSystem.B.dylib library). Also, if I build my environment/library on a PowerPC using the build-on- powerPC-10.3.command, I end up with a different set of link problems involving the long double version of pow(). Besides which, I'd prefer to do my development on OS X for Intel going forward. I have tried hand editing the above routine and rebuilding my Pascal development environment, and pulling the statvfs.h file from my OS X SDK, and yet when my application links, it still has an unresolved reference to _statvfs. I'm not a build engineer, as my previous missives to this mailing list make clear, and I'm at a loss as to how to proceed. Just to be clear, I link in two static libraries: a universal version of the libgpc.a for the runtime, and a universal version of the library I've created. Neither of them contain the symbol _statvfs (at least I can't find that text in them). I link that with my application. The application now references _statvfs (I can now see the text in it's executable). I can't launch on 10.3. I comment out the calls to the Pascal library and recompile+relink, and the application no longer has the symbol and I can launch under 10.3. So something in either of the gpc associated libraries must be calling something which calls statvfs, making the linker (ld) mark statvfs as an unresolved symbol to be loaded in at runtime. At least that is my impression. So, I'd appreciate some suggestions. --glenn

4 8

Memory layout of array of variable size.
by Bastiaan Veelo 24 Dec '07

24 Dec '07

Hi, In an attempt to hook up to GTK+, I am trying to pass a Pascal array of varible size to C. Static arrays are fine, but these arrays carry some additional information like capacity and size, and I gues they could be received as a struct on the C-side. However, I cannot figure out the structure that the struc should have. I do like this in Pascal: procedure YGTK_init(var argc : CInteger; argv : array of CString); external name 'YGTK_init'; procedure Y_init; var argc : CInteger; argv : array[0..ParamCount] of CString; Counter : integer; begin argc := ParamCount+1; for Counter := 0 to ParamCount do begin argv[Counter] := NewCString(ParamStr(Counter)); end; YGTK_init(argc, argv); end; And like this in C: struct t_argv { int end; void *argv; }; void YGTK_init( int *argc, struct t_argv argv ) { printf("In ygtk.c:YGTK_init.\n"); printf("argv.end: %d\n", argv2.argc); printf("argv.argv address: %p\n", argv2.argv); printf("argv.argv int: %d\n", argv2.argv); printf("argv.argv string: %s\n", argv2.argv); printf("number of arguments: %d\n", *argc); } So I figured out that the first element in the struct is an integer containing the length-1 of the array, but what it should look like for the rest I do not know yet. Do you have an idea? Thanks, Bastiaan.

5 9

Implementation of UnixTimeToTime
by Wieland, Patrick 19 Oct '07

19 Oct '07

Hello everyone! I found the function "UnixTimeToTime" in gpc.pas declared as "external" and was wondering where I could find the implementation. May someone please help me? best regards Patrick Wieland

2 1

Generating shared objects with gpc
by Pascal Viandier 17 Oct '07

17 Oct '07

Hi gpc crew, Is there a way to generate a shared object (.so) under unix with gpc? I found nothing about this in GPC documentation. I tried "gpc --automake -o foo.so foo.pas" on the command line (foo.pas being a module) This does not work: I get an error about an undefined reference to 'main' Is it possible at all to generate a shared object with gpc? Does someone have any clue? Regards Pascal Viandier

3 5

[Fwd: GCC 4.2.2 Released]
by Adriaan van Os 10 Oct '07

10 Oct '07

-------- Original Message -------- Subject: GCC 4.2.2 Released Date: Tue, 9 Oct 2007 13:22:19 -0700 From: Mark Mitchell <mark(a)codesourcery.com> Reply-To: mark(a)codesourcery.com To: gcc-announce(a)gcc.gnu.org GCC 4.2.2 has been released. GCC 4.2.2 is a bug-fix release, containing fixes for regressions in GCC 4.2.1 relative to previous GCC releases. This release is available from the FTP servers listed at: http://www.gnu.org/order/ftp.html The compilers in this release are covered by GNU General Public License version 3. See: http://gplv3.fsf.org for more information about GPLv3. Please do not contact me directly regarding questions or comments about this release or about GPLv3. Instead, use the resources available from http://gcc.gnu.org. As always, a vast number of people contributed to this GCC release -- far too many to thank individually! -- Mark Mitchell CodeSourcery mark(a)codesourcery.com (650) 331-3385 x713

1 0

[RFA-2] Handle GPC specific name for main function
by Pierre Muller 08 Oct '07

08 Oct '07

Thanks to Joel for all his contribution, I resubmit a modified version, which is the same as Joel proposed, to the exception that I used "const char *" instead of "const char const *" that I did not find anywhere else in the GDB sources and seems really strange to me... I also modified the final comment inside pascal_main_name. ChangeLog entry: 2007-10-08 Pierre Muller <muller(a)ics.u-strasbg.fr> * p-lang.h (pascal_main_name): Add declaration. * p-lang.c (GPC_P_INITIALIZE, GPC_MAIN_PROGRAM_NAME_1) (GPC_MAIN_PROGRAM_NAME_2): New constants. (pascal_main_name): New function. * symtab.c: Include p-lang.h. (find_main_name): Add call to pascal_main_name. * Makefile.in (symtab.o): Add dependency on p-lang.h. Index: p-lang.h =================================================================== RCS file: /cvs/src/src/gdb/p-lang.h,v retrieving revision 1.12 diff -u -p -r1.12 p-lang.h --- p-lang.h 23 Aug 2007 18:08:36 -0000 1.12 +++ p-lang.h 8 Oct 2007 15:41:43 -0000 @@ -21,6 +21,9 @@ struct value; +/* Defined in p-lang.c */ +extern const char *pascal_main_name (void); + extern int pascal_parse (void); /* Defined in p-exp.y */ extern void pascal_error (char *); /* Defined in p-exp.y */ Index: p-lang.c =================================================================== RCS file: /cvs/src/src/gdb/p-lang.c,v retrieving revision 1.33 diff -u -p -r1.33 p-lang.c --- p-lang.c 23 Sep 2007 16:25:05 -0000 1.33 +++ p-lang.c 8 Oct 2007 15:41:43 -0000 @@ -35,6 +35,56 @@ extern void _initialize_pascal_language (void); +/* All GPC versions until now (2007-09-27) also define a symbol called + '_p_initialize'. Check for the presence of this symbol first. */ +static const char GPC_P_INITIALIZE[] = "_p_initialize"; + +/* The name of the symbol that GPC uses as the name of the main + procedure (since version 20050212). */ +static const char GPC_MAIN_PROGRAM_NAME_1[] = "_p__M0_main_program"; + +/* Older versions of GPC (versions older than 20050212) were using + a different name for the main procedure. */ +static const char GPC_MAIN_PROGRAM_NAME_2[] = "pascal_main_program"; + +/* Function returning the special symbol name used + by GPC for the main procedure in the main program + if it is found in minimal symbol list. + This function tries to find minimal symbols generated by GPC + so that it finds the even if the program was compiled + without debugging information. + According to information supplied by Waldeck Hebisch, + this should work for all versions posterior to June 2000. */ + +const char * +pascal_main_name (void) +{ + struct minimal_symbol *msym; + + msym = lookup_minimal_symbol (GPC_P_INITIALIZE, NULL, NULL); + + /* If '_p_initialize' was not found, the main program is likely not + written in Pascal. */ + if (msym == NULL) + return NULL; + + msym = lookup_minimal_symbol (GPC_MAIN_PROGRAM_NAME_1, NULL, NULL); + if (msym != NULL) + { + return GPC_MAIN_PROGRAM_NAME_1; + } + + msym = lookup_minimal_symbol (GPC_MAIN_PROGRAM_NAME_2, NULL, NULL); + if (msym != NULL) + { + return GPC_MAIN_PROGRAM_NAME_2; + } + + /* No known entry procedure found, the main program is probably + not compiled with GPC. */ + return NULL; +} + /* Determines if type TYPE is a pascal string type. Returns 1 if the type is a known pascal type This function is used by p-valprint.c code to allow better string display. Index: symtab.c =================================================================== RCS file: /cvs/src/src/gdb/symtab.c,v retrieving revision 1.165 diff -u -p -r1.165 symtab.c --- symtab.c 24 Sep 2007 07:40:32 -0000 1.165 +++ symtab.c 8 Oct 2007 15:41:44 -0000 @@ -40,6 +40,7 @@ #include "filenames.h" /* for FILENAME_CMP */ #include "objc-lang.h" #include "ada-lang.h" +#include "p-lang.h" #include "hashtab.h" @@ -4126,7 +4127,7 @@ set_main_name (const char *name) static void find_main_name (void) { - char *new_main_name; + const char *new_main_name; /* Try to see if the main procedure is in Ada. */ /* FIXME: brobecker/2005-03-07: Another way of doing this would @@ -4151,6 +4152,13 @@ find_main_name (void) return; } + new_main_name = pascal_main_name (); + if (new_main_name != NULL) + { + set_main_name (new_main_name); + return; + } + /* The languages above didn't identify the name of the main procedure. Fallback to "main". */ set_main_name ("main"); Index: Makefile.in =================================================================== RCS file: /cvs/src/src/gdb/Makefile.in,v retrieving revision 1.941 diff -u -p -r1.941 Makefile.in --- Makefile.in 8 Oct 2007 15:09:04 -0000 1.941 +++ Makefile.in 8 Oct 2007 15:41:45 -0000 @@ -2751,7 +2751,7 @@ symtab.o: symtab.c $(defs_h) $(symtab_h) $(filenames_h) $(objc_lang_h) $(ada_lang_h) $(hashtab_h) \ $(gdb_obstack_h) $(block_h) $(dictionary_h) $(gdb_string_h) \ $(gdb_stat_h) $(cp_abi_h) $(observer_h) $(gdb_assert_h) \ - $(solist_h) $(ada_lang_h) + $(solist_h) $(p_lang_h) target.o: target.c $(defs_h) $(gdb_string_h) $(target_h) $(gdbcmd_h) \ $(symtab_h) $(inferior_h) $(bfd_h) $(symfile_h) $(objfiles_h) \ $(gdb_wait_h) $(dcache_h) $(regcache_h) $(gdb_assert_h) $(gdbcore_h) \

1 1

Re: [RFC] adding gdb.pascal subdir: updated version
by Pierre Muller 08 Oct '07

08 Oct '07

Thanks for checking this in... Running "make RUNTESTFLAGS=--dir=gdb.pascal" I got the following result with GPC: === gdb Summary === # of expected passes 15 # of unexpected failures 1 # of expected failures 1 # of known failures 1 /usr/local/src/cvs/build/gdb/testsuite/../../gdb/gdb version 6.7.50-20071008-cvs -nx The problem with fpc is that it does not work with cygwin, because cygwin type directories are used, that fpc does not handle. And I have no access to a linux machine here... The gpc specific failure should disappear as soon as I get the pascal_main_name patch in. The known failure is about the string problem, for which I have a fix (only partial) pending. The expected failure is gpc specific too, and comes from the wrong debug information generated. By the way, is this dependent on the type of debug info generated? Does stabs and dwarf both generate the wrong line number information? Pierre Muller GDB pascal language maintainer > -----Original Message----- > From: gdb-patches-owner(a)sourceware.org [mailto:gdb-patches- > owner(a)sourceware.org] On Behalf Of 'Daniel Jacobowitz' > Sent: Monday, October 08, 2007 2:42 PM > To: Pierre Muller > Cc: gdb-patches(a)sourceware.org > Subject: Re: [RFC] adding gdb.pascal subdir: updated version > > On Mon, Oct 08, 2007 at 02:17:54PM +0200, Pierre Muller wrote: > > I am a bit lost in the numerous > > changes that we introduced and I am > > unsure that I have a current complete and up-to-date > > patch, could you commit this change? > > Here's what I checked in. It has a KFAIL for the string type problem, > an XFAIL for gpc's missing line number, and a failure for the GPC > name-of-main issue (could have been a KFAIL but I was tired of waiting > for gnats, and it looks like it will be fixed soon). > > > -- > Daniel Jacobowitz > CodeSourcery > > 2007-10-08 Pierre Muller <muller(a)ics.u-strasbg.fr> > Daniel Jacobowitz <dan(a)codesourcery.com> > > * Makefile.in (ALL_SUBDIRS): Add gdb.pascal. > * configure.ac (AC_OUTPUT): Add gdb.pascal/Makefile. > * configure: Regenerated. > * gdb.pascal/Makefile.in, gdb.pascal/hello.exp, > gdb.pascal/hello.pas, > gdb.pascal/types.exp, lib/pascal.exp: New files. > > Index: Makefile.in > =================================================================== > RCS file: /cvs/src/src/gdb/testsuite/Makefile.in,v > retrieving revision 1.18 > diff -u -p -r1.18 Makefile.in > --- Makefile.in 27 Mar 2007 18:09:35 -0000 1.18 > +++ Makefile.in 8 Oct 2007 12:40:12 -0000 > @@ -37,7 +37,7 @@ RPATH_ENVVAR = @RPATH_ENVVAR@ > ALL_SUBDIRS = gdb.ada gdb.arch gdb.asm gdb.base gdb.cp gdb.disasm \ > gdb.dwarf2 \ > gdb.fortran gdb.server gdb.java gdb.mi \ > - gdb.objc gdb.threads gdb.trace gdb.xml \ > + gdb.objc gdb.pascal gdb.threads gdb.trace gdb.xml \ > $(SUBDIRS) > > EXPECT = `if [ -f $${rootme}/../../expect/expect ] ; then \ > Index: configure > =================================================================== > RCS file: /cvs/src/src/gdb/testsuite/configure,v > retrieving revision 1.24 > diff -u -p -r1.24 configure > --- configure 23 Sep 2007 13:56:56 -0000 1.24 > +++ configure 8 Oct 2007 12:40:12 -0000 > @@ -3104,7 +3104,7 @@ done > > > > - > ac_config_files="$ac_config_files Makefile gdb.ada/Makefile > gdb.arch/Makefile gdb.asm/Makefile gdb.base/Makefile gdb.cp/Makefile > gdb.disasm/Makefile gdb.dwarf2/Makefile gdb.fortran/Makefile > gdb.server/Makefile gdb.java/Makefile gdb.mi/Makefile gdb.objc/Makefile > gdb.threads/Makefile gdb.trace/Makefile gdb.xml/Makefile" > + > ac_config_files="$ac_config_files Makefile gdb.ada/Makefile > gdb.arch/Makefile gdb.asm/Makefile gdb.base/Makefile gdb.cp/Makefile > gdb.disasm/Makefile gdb.dwarf2/Makefile gdb.fortran/Makefile > gdb.server/Makefile gdb.java/Makefile gdb.mi/Makefile gdb.objc/Makefile > gdb.pascal/Makefile gdb.threads/Makefile gdb.trace/Makefile > gdb.xml/Makefile" > cat >confcache <<\_ACEOF > # This file is a shell script that caches the results of configure > # tests run on this system so they can be shared between configure > Index: configure.ac > =================================================================== > RCS file: /cvs/src/src/gdb/testsuite/configure.ac,v > retrieving revision 1.8 > diff -u -p -r1.8 configure.ac > --- configure.ac 23 Sep 2007 13:56:56 -0000 1.8 > +++ configure.ac 8 Oct 2007 12:40:12 -0000 > @@ -115,6 +115,6 @@ AC_OUTPUT([Makefile \ > gdb.arch/Makefile gdb.asm/Makefile gdb.base/Makefile \ > gdb.cp/Makefile gdb.disasm/Makefile gdb.dwarf2/Makefile \ > gdb.fortran/Makefile gdb.server/Makefile \ > - gdb.java/Makefile gdb.mi/Makefile \ > - gdb.objc/Makefile gdb.threads/Makefile gdb.trace/Makefile \ > + gdb.java/Makefile gdb.mi/Makefile gdb.objc/Makefile \ > + gdb.pascal/Makefile gdb.threads/Makefile gdb.trace/Makefile \ > gdb.xml/Makefile]) > Index: gdb.pascal/Makefile.in > =================================================================== > RCS file: gdb.pascal/Makefile.in > diff -N gdb.pascal/Makefile.in > --- /dev/null 1 Jan 1970 00:00:00 -0000 > +++ gdb.pascal/Makefile.in 8 Oct 2007 12:40:12 -0000 > @@ -0,0 +1,24 @@ > +VPATH = @srcdir@ > +srcdir = @srcdir@ > + > +EXECUTABLES = hello/hello > + > +MISCELLANEOUS = > + > +all info install-info dvi install uninstall installcheck check: > + @echo "Nothing to be done for $@..." > + > +clean mostlyclean: > + -find . -name '*.o' -print | xargs rm -f > + -find . -name '*.ali' -print | xargs rm -f > + -find . -name 'b~*.ad[sb]' -print | xargs rm -f > + -rm -f *~ a.out xgdb *.x *.ci *.tmp > + -rm -f *~ *.o a.out xgdb *.x *.ci *.tmp > + -rm -f core core.coremaker coremaker.core corefile $(EXECUTABLES) > + -rm -f $(MISCELLANEOUS) twice-tmp.c > + > +distclean maintainer-clean realclean: clean > + -rm -f *~ core > + -rm -f Makefile config.status config.log > + -rm -f *-init.exp > + -rm -fr *.log summary detail *.plog *.sum *.psum site.* > Index: gdb.pascal/hello.exp > =================================================================== > RCS file: gdb.pascal/hello.exp > diff -N gdb.pascal/hello.exp > --- /dev/null 1 Jan 1970 00:00:00 -0000 > +++ gdb.pascal/hello.exp 8 Oct 2007 12:40:12 -0000 > @@ -0,0 +1,75 @@ > +# Copyright 2007 Free Software Foundation, Inc. > +# > +# This program is free software; you can redistribute it and/or modify > +# it under the terms of the GNU General Public License as published by > +# the Free Software Foundation; either version 3 of the License, or > +# (at your option) any later version. > +# > +# This program is distributed in the hope that it will be useful, > +# but WITHOUT ANY WARRANTY; without even the implied warranty of > +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > +# GNU General Public License for more details. > +# > +# You should have received a copy of the GNU General Public License > +# along with this program. If not, see > <http://www.gnu.org/licenses/>. > + > +if $tracelevel then { > + strace $tracelevel > +} > + > +load_lib "pascal.exp" > + > +set testfile "hello" > +set srcfile ${testfile}.pas > +set binfile ${objdir}/${subdir}/${testfile} > + > +if {[gdb_compile_pascal "${srcdir}/${subdir}/${srcfile}" "${binfile}" > executable [list debug ]] != "" } { > + return -1 > +} > + > +gdb_exit > +gdb_start > +gdb_reinitialize_dir $srcdir/$subdir > +gdb_load ${binfile} > +set bp_location1 [gdb_get_line_number "set breakpoint 1 here"] > +set bp_location2 [gdb_get_line_number "set breakpoint 2 here"] > + > +if { [gdb_breakpoint ${srcfile}:${bp_location1}] } { > + pass "setting breakpoint 1" > +} > +if { [gdb_breakpoint ${srcfile}:${bp_location2}] } { > + pass "setting breakpoint 2" > +} > + > +# Verify that "start" lands inside the right procedure. > +if { [gdb_start_cmd] < 0 } { > + untested start > + return -1 > +} > + > +# This test fails for gpc > +# because debug information for 'main' > +# is in some <implicit code> > +gdb_test "" \ > + ".* at .*hello.pas.*" \ > + "start" > + > +gdb_test "cont" \ > + "Breakpoint .*:${bp_location1}.*" \ > + "Going to first breakpoint" > +gdb_test "print st" \ > + ".* = ''.*" \ > + "Empty string check" > + > +# This test also fails for gpc because the program > +# stops after the string has been written > +# while it should stop before writing it > +if { $pascal_compiler_is_gpc } { > + setup_xfail *-*-* > +} > +gdb_test "cont" \ > + "Breakpoint .*:${bp_location2}.*" \ > + "Going to second breakpoint" > +gdb_test "print st" \ > + ".* = 'Hello, world!'.*" \ > + "String after assignment check" > Index: gdb.pascal/hello.pas > =================================================================== > RCS file: gdb.pascal/hello.pas > diff -N gdb.pascal/hello.pas > --- /dev/null 1 Jan 1970 00:00:00 -0000 > +++ gdb.pascal/hello.pas 8 Oct 2007 12:40:12 -0000 > @@ -0,0 +1,15 @@ > +program hello; > + > +var > + st : string; > + > +procedure print_hello; > +begin > + Writeln('Before assignment'); { set breakpoint 1 here } > + st:='Hello, world!'; > + writeln(st); {set breakpoint 2 here } > +end; > + > +begin > + print_hello; > +end. > Index: gdb.pascal/types.exp > =================================================================== > RCS file: gdb.pascal/types.exp > diff -N gdb.pascal/types.exp > --- /dev/null 1 Jan 1970 00:00:00 -0000 > +++ gdb.pascal/types.exp 8 Oct 2007 12:40:12 -0000 > @@ -0,0 +1,110 @@ > +# Copyright 1994, 1995, 1997, 1998, 2007 Free Software Foundation, > Inc. > +# Copyright 2007 Free Software Foundation, Inc. > +# > +# This program is free software; you can redistribute it and/or modify > +# it under the terms of the GNU General Public License as published by > +# the Free Software Foundation; either version 3 of the License, or > +# (at your option) any later version. > +# > +# This program is distributed in the hope that it will be useful, > +# but WITHOUT ANY WARRANTY; without even the implied warranty of > +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > +# GNU General Public License for more details. > +# > +# You should have received a copy of the GNU General Public License > +# along with this program. If not, see > <http://www.gnu.org/licenses/>. > + > +# Please email any bugs, comments, and/or additions to this file to: > +# bug-gdb(a)prep.ai.mit.edu > + > +# This file was adapted from old Chill tests by Stan Shebs > +# (shebs(a)cygnus.com). > +# Adapted to pascal by Pierre Muller > + > +if $tracelevel then { > + strace $tracelevel > +} > + > +set prms_id 0 > +set bug_id 0 > + > +# Set the current language to pascal. This counts as a test. If it > +# fails, then we skip the other tests. > + > +proc set_lang_pascal {} { > + global gdb_prompt > + > + if [gdb_test "set language pascal" ""] { > + return 0; > + } > + > + if ![gdb_test "show language" ".* source language is > \"pascal\".*"] { > + return 1; > + } else { > + return 0; > + } > +} > + > +proc test_integer_literal_types_accepted {} { > + global gdb_prompt > + > + # Test various decimal values. > + # Should be integer*4 probably. > + gdb_test "pt 123" "type = int" > +} > +proc test_character_literal_types_accepted {} { > + global gdb_prompt > + > + # Test various character values. > + > + gdb_test "pt 'a'" "type = char" > +} > + > +proc test_string_literal_types_accepted {} { > + global gdb_prompt > + > + # Test various character values. > + > + setup_kfail *-*-* gdb/2326 > + gdb_test "pt 'a simple string'" "type = string" > +} > + > +proc test_logical_literal_types_accepted {} { > + global gdb_prompt > + > + # Test the only possible values for a logical, TRUE and FALSE. > + > + gdb_test "pt TRUE" "type = bool" > + gdb_test "pt FALSE" "type = bool" > +} > + > +proc test_float_literal_types_accepted {} { > + global gdb_prompt > + > + # Test various floating point formats > + > + # this used to guess whether to look for "real*4" or > + # "real*8" based on a target config variable, but noone > + # maintained it properly. > + > + gdb_test "pt .44" "type = double" > + gdb_test "pt 44.0" "type = double" > + gdb_test "pt 10e20" "type = double" > + gdb_test "pt 10E20" "type = double" > +} > + > +# Start with a fresh gdb. > + > +gdb_exit > +gdb_start > +gdb_reinitialize_dir $srcdir/$subdir > + > +if [set_lang_pascal] then { > + test_integer_literal_types_accepted > + test_logical_literal_types_accepted > + test_character_literal_types_accepted > + test_string_literal_types_accepted > + test_float_literal_types_accepted > +} else { > + warning "$test_name tests suppressed." 0 > +} > Index: lib/pascal.exp > =================================================================== > RCS file: lib/pascal.exp > diff -N lib/pascal.exp > --- /dev/null 1 Jan 1970 00:00:00 -0000 > +++ lib/pascal.exp 8 Oct 2007 12:40:12 -0000 > @@ -0,0 +1,152 @@ > +# Copyright 2007 Free Software Foundation, Inc. > +# > +# This program is free software; you can redistribute it and/or modify > +# it under the terms of the GNU General Public License as published by > +# the Free Software Foundation; either version 3 of the License, or > +# (at your option) any later version. > +# > +# This program is distributed in the hope that it will be useful, > +# but WITHOUT ANY WARRANTY; without even the implied warranty of > +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > +# GNU General Public License for more details. > +# > +# You should have received a copy of the GNU General Public License > +# along with this program. If not, see > <http://www.gnu.org/licenses/>. > + > +load_lib libgloss.exp > + > +set pascal_init_done 0 > + > +# This procedure looks for a suitable pascal compiler > +# For now only GNU pascal compiler and Free Pascal compiler > +# are searched. > +# First, environment variable GPC is checked > +# if present, GPC compiler is assumed to be the value of > +# that environment variable. > +# Second, environment variable FPC is checked > +# if present, Free Pascal compiler is assumed to be the value of > +# that environment variable. > +# Third, gpc executable is searched using `which gpc` > +# Lastly, fpc executable is searched using `which fpc` > +# Using environment variable allows to force > +# which compiler is used in testsuite > + > +proc pascal_init {} { > + global pascal_init_done > + global pascal_compiler_is_gpc > + global pascal_compiler_is_fpc > + global gpc_compiler > + global fpc_compiler > + global env > + > + if { $pascal_init_done == 1 } { > + return > + } > + > + set pascal_compiler_is_gpc 0 > + set pascal_compiler_is_fpc 0 > + set gpc_compiler [transform gpc] > + set fpc_compiler [transform fpc] > + > + if ![is_remote host] { > + if { [info exists env(GPC)] } { > + set pascal_compiler_is_gpc 1 > + set gpc_compiler $env(GPC) > + verbose -log "Assuming GNU Pascal ($gpc_compiler)" > + } elseif { [info exists env(FPC)] } { > + set pascal_compiler_is_fpc 1 > + set fpc_compiler $env(FPC) > + verbose -log "Assuming Free Pascal ($fpc_compiler)" > + } elseif { [which $gpc_compiler] != 0 } { > + set pascal_compiler_is_gpc 1 > + verbose -log "GNU Pascal compiler found" > + } elseif { [which $fpc_compiler] != 0 } { > + set pascal_compiler_is_fpc 1 > + verbose -log "Free Pascal compiler found" > + } > + } > + set pascal_init_done 1 > +} > + > +proc gpc_compile {source dest type options} { > + global gpc_compiler > + set add_flags "" > + if {$type == "object"} { > + append add_flags " -c" > + } > + > + if { $type == "preprocess" } { > + append add_flags " -E" > + } > + > + if { $type == "assembly" } { > + append add_flags " -S" > + } > + > + foreach i $options { > + if { $i == "debug" } { > + if [board_info $dest exists debug_flags] { > + append add_flags " [board_info $dest debug_flags]"; > + } else { > + append add_flags " -g" > + } > + } > + } > + > + set result [remote_exec host $gpc_compiler "-o $dest --automake > $add_flags $source"] > + return $result > +} > + > +proc fpc_compile {source dest type options} { > + global fpc_compiler > + set add_flags "" > + if {$type == "object"} { > + append add_flags " -Cn" > + } > + > + if { $type == "preprocess" } { > + return "Free Pascal can not preprocess" > + } > + > + if { $type == "assembly" } { > + append add_flags " -al" > + } > + > + foreach i $options { > + if { $i == "debug" } { > + if [board_info $dest exists debug_flags] { > + append add_flags " [board_info $dest debug_flags]"; > + } else { > + append add_flags " -g" > + } > + } > + } > + > + set result [remote_exec host $fpc_compiler "-o$dest $add_flags > $source"] > + return $result > +} > + > +proc gdb_compile_pascal {source dest type options} { > + global pascal_init_done > + global pascal_compiler_is_gpc > + global pascal_compiler_is_fpc > + > + if { $pascal_init_done == 0 } { > + pascal_init > + } > + > + if { $pascal_compiler_is_fpc == 1 } { > + set result [fpc_compile $source $dest $type $options] > + } elseif { $pascal_compiler_is_gpc == 1 } { > + set result [gpc_compile $source $dest $type $options] > + } else { > + unsupported "No pascal compiler found" > + return "No pascal compiler. Compilation failed." > + } > + > + if ![file exists $dest] { > + unsupported "Pascal compilation failed: $result" > + return "Pascal compilation failed." > + } > +} > +

1 0

Re: [RFC] adding gdb.pascal subdir: updated version
by Pierre Muller 08 Oct '07

08 Oct '07

This is the BIG problem about GDB pascal expression parser: - the single quotes are used in the C expression parser for these "quoted symbol reference", which I did not want to remove from the pascal expression parser, mainly because I did not really know what its use was, and I still don't know :(. Question to GPC people: does anyone use this "quoted symbol reference"? I thought that it could be very useful for overloaded functions (functions having the same name, but a diffent arg list, which is allowed in pascal). Thus I also left the double quote parsing as a string constant even though it is not the real pascal syntax. - but pascal strings are started by single quotes, not double quotes... I have a patch that would still search for quoted symbol reference, but would default to a pascal string in case nothing is found. The patch is rather simple, it just sets a variable named is_pascal_string, that is used if no symbol is found later to transform the character sequence into a real string. See diff below. The main problem is that doing this would give you subtle bugs like (gdb) pt 'Hello world' (gdb) type = array [0..11] of char (gdb) pt 'main' type = function .... Which is not really nice. I wanted to wait until the pascal subdirectory of the testsuite is added to start coping with this BIG problem... Index: p-exp.y =================================================================== RCS file: /cvs/src/src/gdb/p-exp.y,v retrieving revision 1.36 diff -u -p -r1.36 p-exp.y --- p-exp.y 3 Jul 2007 01:01:13 -0000 1.36 +++ p-exp.y 25 Sep 2007 15:52:23 -0000 @@ -1062,11 +1063,12 @@ yylex () int explen, tempbufindex; static char *tempbuf; static int tempbufsize; + int is_pascal_string; retry: prev_lexptr = lexptr; - + is_pascal_string = 0; tokstart = lexptr; explen = strlen (lexptr); /* See if it is a special token of length 3. */ @@ -1129,6 +1131,7 @@ yylex () error ("Unmatched single quote."); namelen -= 2; tokstart++; + is_pascal_string = 1; uptokstart = uptok(tokstart,namelen); goto tryname; } @@ -1648,6 +1651,16 @@ yylex () /* Any other kind of symbol */ yylval.ssym.sym = sym; yylval.ssym.is_a_field_of_this = is_a_field_of_this; + if (!sym && is_pascal_string) + { + /* Handle this as a normal pascal string. */ + tempbuf = (char *) realloc (tempbuf, namelen + 1); + strncpy (tempbuf, tokstart, namelen); + tempbuf[namelen] = '\0'; + yylval.sval.ptr = tempbuf; + yylval.sval.length = namelen; + return (STRING); + } return NAME; } } > -----Original Message----- > From: gdb-patches-owner(a)sourceware.org [mailto:gdb-patches- > owner(a)sourceware.org] On Behalf Of 'Daniel Jacobowitz' > Sent: Saturday, October 06, 2007 5:42 PM > To: Pierre Muller > Cc: gdb-patches(a)sourceware.org; gpc(a)gnu.de > Subject: Re: [RFC] adding gdb.pascal subdir: updated version > > On Sat, Sep 08, 2007 at 12:38:47AM +0200, Pierre Muller wrote: > > +proc test_string_literal_types_accepted {} { > > + global gdb_prompt > > + > > + # Test various character values. > > + > > + gdb_test "pt 'a simple string'" "type = string" > > +} > > Pierre, is this the correct Pascal syntax for a string or not? > > We have: > > case '\'': > /* We either have a character constant ('0' or '\177' for > example) > or we have a quoted symbol reference ('foo(int,int)' in object > pascal > for example). */ > > and there is a separate case for double-quoted strings. > > Resolving that question will take care of one failure for both fpc and > gpc. The other two GPC failures should be handled like in the patch > I've attached. The failure at "start" is a GDB bug, so we label that > a KFAIL ("known failure"). The shouldn't be committed with gdb/NNNN > still in it. It should either have a bug number in our bug database, > or else just wait until the patch to fix it is checked in. > > The other test is definitely a bug in GPC. I read through the DWARF > dump and there is no reference to line 10, so GDB will never display > it. So that's an XFAIL, an expected failure due to our environment. > It needs to get a little more complicated if the GPC bug is fixed > some day, using gdb_test_multiple. > > -- > Daniel Jacobowitz > CodeSourcery > > diff -u gdb.pascal/hello.exp gdb.pascal/hello.exp > --- gdb.pascal/hello.exp 7 Sep 2007 21:46:31 -0000 > +++ gdb.pascal/hello.exp 6 Oct 2007 15:39:32 -0000 > @@ -50,6 +50,9 @@ > # This test fails for gpc > # because debug information for 'main' > # is in some <implicit code> > +if { $pascal_compiler_is_gpc } { > + setup_kfail *-*-* gdb/NNNN > +} > gdb_test "" \ > ".* at .*hello.pas.*" \ > "start" > @@ -64,6 +67,9 @@ > # This test also fails for gpc because the program > # stops after the string has been written > # while it should stop before writing it > +if { $pascal_compiler_is_gpc } { > + setup_xfail *-*-* > +} > gdb_test "cont" \ > "Breakpoint .*:${bp_location2}.*" \ > "Going to second breakpoint"

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

2000

1999

1998

1997

1996

1995

Gpc October 2007