Hallo Frank,
Am Freitag, 10. Oktober 2003 um 01:13 schriebst du:
Gerrit P. Haase wrote:
That being said, it is quite straightforward to build PDCurses for Cygwin and Mingw.
Then there should be an option for the user to decide whether she wants to use PD- or Ncurses.
Well, this option is just `USE_NCURSES'/`USE_PDCURSES' which I mentioned.
So, what your patch does is just to change the default under Cygwin from PDCurses to ncurses. I'd accept it if it's widely preferred (by Cygwin/GPC users), and/or ncurses is objectively better than PDCurses under Cygwin (less bugs, better performance, better support of special features, see comment in crt.pas, etc.).
It is included in the netrelease and distributed through the mirrors. But wait until I finished the build and have the testsummary.
I'll wait to hear of such preferences or evidence until I change anything.
See above.
What I meant in a previous mail is to automate this setting in the test suite. The affected test programs use a "curses detection" script, anyway, so it could set the respective flag. This will take a little effort (but probably not too much) in the scripts (crt.cmp etc.). Then at least the tests would work regardless of the default setting.
(BTW, your patch has a little problem: Due to the higher precedence of `&&' vs. `||' the `__CYGWIN__' test would only refer to `XCURSES'. And in fact the `&& !defined(__CYGWIN__)' is redundant since none of the other symbols should be defined on Cygwin, anyway.)
Yes of course, but we need to be sure, sometimes some weird things happen here on cygwin and suddenly you have defined WIN32 and don't know about it. We make it always bulletproof, that is: never trust the user and never define WIN32 && CYGWIN together or always use WIN32 and __CYGWIN__ exclusively.
Gerrit