Waldek Hebisch wrote:
Frank Heckenbach wrote:
(And, BTW, if you want it included in the GPC distribution, please note the GPC Coding Standards. If I'd have to reformat the code or do other significant work with it, I won't do it, see above. Also, please don't change `* $10' to `shl 4' etc., as you did. Write high-level code and leave the low-level optimizations to the compiler.)
AFAIKS intended operation is a shift. So `shl 4' is a high-level specification and `* $10' buys nothing. I can understand that uglyfication to `* 16' gives more portable code, but the unit uses shifts anyway.
Except, if you look at ISO 10206, there is no mention of any operator 'shl'. I don't believe $10 is mentioned either. Which, to my mind, leaves '* 16'.