I have created a patch that adds a define to include/ansidecl.h. When I build the compiler with the patch, the build hangs as indicated below.
My questions are:
1. What's going on ? 2. Is there a configuration file in gcc/p or gcc/p/rts that needs a manual rebuild after the patch ? 3. Is there a recommended way to add a define to the compilation of all files (including libiberty) ?
Regards,
Adriaan van Os
stage1/xgcc -Bstage1/ -B/Developer/Pascal/gpc346u4/i386-apple-darwin10/bin/ -g -O2 -DIN_GCC -W -Wall -Wwrite-strings -Wstrict-prototypes -Wmissing-prototypes -pedantic -Wno-long-long -Wold-style-definition -DHAVE_CONFIG_H -o xgcc gcc.o gccspec.o intl.o \ prefix.o version.o ../libiberty/libiberty.a -liconv ./xgcc -B./ -B/Developer/Pascal/gpc346u4/i386-apple-darwin10/bin/ -isystem /Developer/Pascal/gpc346u4/i386-apple-darwin10/include -isystem /Developer/Pascal/gpc346u4/i386-apple-darwin10/sys-include -L/Volumes/P300/Users/adriaan/gnu/gpc/gpc346u4/build/gcc/../ld -dumpspecs > tmp-specs mv tmp-specs specs cd ../../gcc-3.4.6/gcc/p/rts && make -f Makefile.in srcdir=. GCC_VERSION="3.4.6" SHELL="/bin/sh" CFLAGS="-g -O2" PFLAGS="" AR_FLAGS="rc" RTSFLAGS="" DESTDIR="../.." AR="` if [ -f /Volumes/P300/Users/adriaan/gnu/gpc/gpc346u4/build/gcc/../binutils/ar ] ; then echo /Volumes/P300/Users/adriaan/gnu/gpc/gpc346u4/build/gcc/../binutils/ar ; else if [ "i386-apple-darwin10" = "i386-apple-darwin10" ] ; then echo ar; else t='s,y,y,'; echo ar | sed -e $t ; fi; fi`" RANLIB="` if [ -f /Volumes/P300/Users/adriaan/gnu/gpc/gpc346u4/build/gcc/../binutils/ranlib ] ; then echo /Volumes/P300/Users/adriaan/gnu/gpc/gpc346u4/build/gcc/../binutils/ranlib ; else if [ "i386-apple-darwin10" = "i386-apple-darwin10" ] ; then echo ranlib; else t='s,y,y,'; echo ranlib | sed -e $t ; fi; fi`" RANLIB_TEST="" generated-files make[3]: Nothing to be done for `generated-files'. cd ../../gcc-3.4.6/gcc/p/rts && make -f Makefile.in srcdir=. GCC_VERSION="3.4.6" SHELL="/bin/sh" CFLAGS="-g -O2" PFLAGS="" AR_FLAGS="rc" RTSFLAGS="" DESTDIR="../.." AR="` if [ -f /Volumes/P300/Users/adriaan/gnu/gpc/gpc346u4/build/gcc/../binutils/ar ] ; then echo /Volumes/P300/Users/adriaan/gnu/gpc/gpc346u4/build/gcc/../binutils/ar ; else if [ "i386-apple-darwin10" = "i386-apple-darwin10" ] ; then echo ar; else t='s,y,y,'; echo ar | sed -e $t ; fi; fi`" RANLIB="` if [ -f /Volumes/P300/Users/adriaan/gnu/gpc/gpc346u4/build/gcc/../binutils/ranlib ] ; then echo /Volumes/P300/Users/adriaan/gnu/gpc/gpc346u4/build/gcc/../binutils/ranlib ; else if [ "i386-apple-darwin10" = "i386-apple-darwin10" ] ; then echo ranlib; else t='s,y,y,'; echo ranlib | sed -e $t ; fi; fi`" RANLIB_TEST="" generated-files make[3]: Nothing to be done for `generated-files'. cd ../../gcc-3.4.6/gcc/p/rts && make -f Makefile.in srcdir=. GCC_VERSION="3.4.6" SHELL="/bin/sh" CFLAGS="-g -O2" PFLAGS="" AR_FLAGS="rc" RTSFLAGS="" DESTDIR="../.." AR="` if [ -f /Volumes/P300/Users/adriaan/gnu/gpc/gpc346u4/build/gcc/../binutils/ar ] ; then echo /Volumes/P300/Users/adriaan/gnu/gpc/gpc346u4/build/gcc/../binutils/ar ; else if [ "i386-apple-darwin10" = "i386-apple-darwin10" ] ; then echo ar; else t='s,y,y,'; echo ar | sed -e $t ; fi; fi`" RANLIB="` if [ -f /Volumes/P300/Users/adriaan/gnu/gpc/gpc346u4/build/gcc/../binutils/ranlib ] ; then echo /Volumes/P300/Users/adriaan/gnu/gpc/gpc346u4/build/gcc/../binutils/ranlib ; else if [ "i386-apple-darwin10" = "i386-apple-darwin10" ] ; then echo ranlib; else t='s,y,y,'; echo ranlib | sed -e $t ; fi; fi`" RANLIB_TEST="" generated-files make[3]: Nothing to be done for `generated-files'. cd ../../gcc-3.4.6/gcc/p/rts && make -f Makefile.in srcdir=. GCC_VERSION="3.4.6" SHELL="/bin/sh" CFLAGS="-g -O2" PFLAGS="" AR_FLAGS="rc" RTSFLAGS="" DESTDIR="../.." AR="` if [ -f /Volumes/P300/Users/adriaan/gnu/gpc/gpc346u4/build/gcc/../binutils/ar ] ; then echo /Volumes/P300/Users/adriaan/gnu/gpc/gpc346u4/build/gcc/../binutils/ar ; else if [ "i386-apple-darwin10" = "i386-apple-darwin10" ] ; then echo ar; else t='s,y,y,'; echo ar | sed -e $t ; fi; fi`" RANLIB="` if [ -f /Volumes/P300/Users/adriaan/gnu/gpc/gpc346u4/build/gcc/../binutils/ranlib ] ; then echo /Volumes/P300/Users/adriaan/gnu/gpc/gpc346u4/build/gcc/../binutils/ranlib ; else if [ "i386-apple-darwin10" = "i386-apple-darwin10" ] ; then echo ranlib; else t='s,y,y,'; echo ranlib | sed -e $t ; fi; fi`" RANLIB_TEST="" generated-files make[3]: Nothing to be done for `generated-files'. cd ../../gcc-3.4.6/gcc/p/rts && make -f Makefile.in srcdir=. GCC_VERSION="3.4.6" SHELL="/bin/sh" CFLAGS="-g -O2" PFLAGS="" AR_FLAGS="rc" RTSFLAGS="" DESTDIR="../.." AR="` if [ -f /Volumes/P300/Users/adriaan/gnu/gpc/gpc346u4/build/gcc/../binutils/ar ] ; then echo /Volumes/P300/Users/adriaan/gnu/gpc/gpc346u4/build/gcc/../binutils/ar ; else if [ "i386-apple-darwin10" = "i386-apple-darwin10" ] ; then echo ar; else t='s,y,y,'; echo ar | sed -e $t ; fi; fi`" RANLIB="` if [ -f /Volumes/P300/Users/adriaan/gnu/gpc/gpc346u4/build/gcc/../binutils/ranlib ] ; then echo /Volumes/P300/Users/adriaan/gnu/gpc/gpc346u4/build/gcc/../binutils/ranlib ; else if [ "i386-apple-darwin10" = "i386-apple-darwin10" ] ; then echo ranlib; else t='s,y,y,'; echo ranlib | sed -e $t ; fi; fi`" RANLIB_TEST="" generated-files make[3]: Nothing to be done for `generated-files'. rm -rf p/docdemos ../../gcc-3.4.6/gcc/p/script/mkdir-p p/docdemos ../../gcc-3.4.6/gcc/p/script/extract-doc-demos -o p/docdemos ../../gcc-3.4.6/gcc/p/doc/*.texi ../../gcc-3.4.6/gcc/p/doc/generated/*.texi ../../gcc-3.4.6/gcc/p/doc/en/*.texi echo timestamp > "p/stamp-docdemos" make[2]: Circular libgcc.a <- pascal dependency dropped. if [ -f specs.ready ] ; then \ true; \ else \ echo timestamp > specs.ready; \ fi objext='.o' \ LIB1ASMFUNCS='' \ LIB2FUNCS_ST='_eprintf __gcc_bcmp' \ LIBGCOV='_gcov _gcov_merge_add _gcov_merge_single _gcov_merge_delta' \ LIB2ADD='' \ LIB2ADD_ST='' \ LIB2ADD_SH='' \ LIB2ADDEH='../../gcc-3.4.6/gcc/unwind-dw2.c ../../gcc-3.4.6/gcc/unwind-dw2-fde-darwin.c ../../gcc-3.4.6/gcc/unwind-sjlj.c ../../gcc-3.4.6/gcc/unwind-c.c' \ LIB2ADDEHSTATIC='../../gcc-3.4.6/gcc/unwind-dw2.c ../../gcc-3.4.6/gcc/unwind-dw2-fde-darwin.c ../../gcc-3.4.6/gcc/unwind-sjlj.c ../../gcc-3.4.6/gcc/unwind-c.c' \ LIB2ADDEHSHARED='../../gcc-3.4.6/gcc/unwind-dw2.c ../../gcc-3.4.6/gcc/unwind-dw2-fde-darwin.c ../../gcc-3.4.6/gcc/unwind-sjlj.c ../../gcc-3.4.6/gcc/unwind-c.c' \ LIB2ADDEHDEP='unwind.inc unwind-dw2-fde.h unwind-dw2-fde.c' \ LIBUNWIND='' \ LIBUNWINDDEP='' \ SHLIBUNWIND_LINK='' \ SHLIBUNWIND_INSTALL='' \ FPBIT='' \ FPBIT_FUNCS='_pack_sf _unpack_sf _addsub_sf _mul_sf _div_sf _fpcmp_parts_sf _compare_sf _eq_sf _ne_sf _gt_sf _ge_sf _lt_sf _le_sf _unord_sf _si_to_sf _sf_to_si _negate_sf _make_sf _sf_to_df _sf_to_tf _thenan_sf _sf_to_usi _usi_to_sf' \ LIB2_DIVMOD_FUNCS='_divdi3 _moddi3 _udivdi3 _umoddi3 _udiv_w_sdiv _udivmoddi4' \ DPBIT='' \ DPBIT_FUNCS='_pack_df _unpack_df _addsub_df _mul_df _div_df _fpcmp_parts_df _compare_df _eq_df _ne_df _gt_df _ge_df _lt_df _le_df _unord_df _si_to_df _df_to_si _negate_df _make_df _df_to_sf _df_to_tf _thenan_df _df_to_usi _usi_to_df' \ TPBIT='' \ TPBIT_FUNCS='_pack_tf _unpack_tf _addsub_tf _mul_tf _div_tf _fpcmp_parts_tf _compare_tf _eq_tf _ne_tf _gt_tf _ge_tf _lt_tf _le_tf _unord_tf _si_to_tf _tf_to_si _negate_tf _make_tf _tf_to_df _tf_to_sf _thenan_tf _tf_to_usi _usi_to_tf' \ MULTILIBS=` ./xgcc -B./ -B/Developer/Pascal/gpc346u4/i386-apple-darwin10/bin/ -isystem /Developer/Pascal/gpc346u4/i386-apple-darwin10/include -isystem /Developer/Pascal/gpc346u4/i386-apple-darwin10/sys-include -L/Volumes/P300/Users/adriaan/gnu/gpc/gpc346u4/build/gcc/../ld --print-multi-lib` \ EXTRA_MULTILIB_PARTS='' \ SHLIB_LINK='' \ SHLIB_INSTALL='' \ SHLIB_EXT='' \ SHLIB_MULTILIB='' \ SHLIB_MKMAP='' \ SHLIB_MKMAP_OPTS='' \ SHLIB_MAPFILES='' \ SHLIB_NM_FLAGS='-pg' \ MULTILIB_OSDIRNAMES='' \ mkinstalldirs='/bin/sh ../../gcc-3.4.6/gcc/mkinstalldirs' \ /bin/sh mklibgcc > tmp-libgcc.mk xgcc: unrecognized option `-isystem' xgcc: unrecognized option `-isystem' mv tmp-libgcc.mk libgcc.mk ./xgcc -B./ -B/Developer/Pascal/gpc346u4/i386-apple-darwin10/bin/ -isystem /Developer/Pascal/gpc346u4/i386-apple-darwin10/include -isystem /Developer/Pascal/gpc346u4/i386-apple-darwin10/sys-include -L/Volumes/P300/Users/adriaan/gnu/gpc/gpc346u4/build/gcc/../ld -DIN_GCC -W -Wall -Wwrite-strings -Wstrict-prototypes -Wmissing-prototypes -Wold-style-definition -isystem ./include -I. -I. -I../../gcc-3.4.6/gcc -I../../gcc-3.4.6/gcc/. -I../../gcc-3.4.6/gcc/../include \ -c ../../gcc-3.4.6/gcc/config/darwin-crt2.c -o crt2.o xgcc: unrecognized option `-isystem' xgcc: unrecognized option `-isystem' xgcc: unrecognized option `-DIN_GCC' xgcc: unrecognized option `-isystem' xgcc: unrecognized option `-I.' xgcc: unrecognized option `-I.' xgcc: unrecognized option `-I../../gcc-3.4.6/gcc' xgcc: unrecognized option `-I../../gcc-3.4.6/gcc/.' xgcc: unrecognized option `-I../../gcc-3.4.6/gcc/../include'
Adriaan van Os wrote:
I have created a patch that adds a define to include/ansidecl.h. When I build the compiler with the patch, the build hangs as indicated below.
My questions are:
- What's going on ?
- Is there a configuration file in gcc/p or gcc/p/rts that needs a manual rebuild after the patch ?
- Is there a recommended way to add a define to the compilation of all files (including libiberty) ?
./xgcc -B./ -B/Developer/Pascal/gpc346u4/i386-apple-darwin10/bin/ -isystem /Developer/Pascal/gpc346u4/i386-apple-darwin10/include -isystem /Developer/Pascal/gpc346u4/i386-apple-darwin10/sys-include -L/Volumes/P300/Users/adriaan/gnu/gpc/gpc346u4/build/gcc/../ld -DIN_GCC -W -Wall -Wwrite-strings -Wstrict-prototypes -Wmissing-prototypes -Wold-style-definition -isystem ./include -I. -I. -I../../gcc-3.4.6/gcc -I../../gcc-3.4.6/gcc/. -I../../gcc-3.4.6/gcc/../include \ -c ../../gcc-3.4.6/gcc/config/darwin-crt2.c -o crt2.o xgcc: unrecognized option `-isystem' xgcc: unrecognized option `-isystem' xgcc: unrecognized option `-DIN_GCC' xgcc: unrecognized option `-isystem' xgcc: unrecognized option `-I.' xgcc: unrecognized option `-I.' xgcc: unrecognized option `-I../../gcc-3.4.6/gcc' xgcc: unrecognized option `-I../../gcc-3.4.6/gcc/.' xgcc: unrecognized option `-I../../gcc-3.4.6/gcc/../include'
Looks that you have broken option parser. I am affraid that without seeing that actual patch it is hard to say more.
Concerning adding a global define: have you tried passing modified CFLAGS to make?
Waldek Hebisch wrote:
Adriaan van Os wrote:
I have created a patch that adds a define to include/ansidecl.h. When I build the compiler with the patch, the build hangs as indicated below.
My questions are:
- What's going on ?
- Is there a configuration file in gcc/p or gcc/p/rts that needs a manual rebuild after the patch ?
- Is there a recommended way to add a define to the compilation of all files (including libiberty) ?
./xgcc -B./ -B/Developer/Pascal/gpc346u4/i386-apple-darwin10/bin/ -isystem /Developer/Pascal/gpc346u4/i386-apple-darwin10/include -isystem /Developer/Pascal/gpc346u4/i386-apple-darwin10/sys-include -L/Volumes/P300/Users/adriaan/gnu/gpc/gpc346u4/build/gcc/../ld -DIN_GCC -W -Wall -Wwrite-strings -Wstrict-prototypes -Wmissing-prototypes -Wold-style-definition -isystem ./include -I. -I. -I../../gcc-3.4.6/gcc -I../../gcc-3.4.6/gcc/. -I../../gcc-3.4.6/gcc/../include \ -c ../../gcc-3.4.6/gcc/config/darwin-crt2.c -o crt2.o xgcc: unrecognized option `-isystem' xgcc: unrecognized option `-isystem' xgcc: unrecognized option `-DIN_GCC' xgcc: unrecognized option `-isystem' xgcc: unrecognized option `-I.' xgcc: unrecognized option `-I.' xgcc: unrecognized option `-I../../gcc-3.4.6/gcc' xgcc: unrecognized option `-I../../gcc-3.4.6/gcc/.' xgcc: unrecognized option `-I../../gcc-3.4.6/gcc/../include'
Looks that you have broken option parser. I am affraid that without seeing that actual patch it is hard to say more.
The Mac OS X headers for /usr/include/string.h and /usr/include/stdio.h forget to check for the GCC version when using a feature http://gcc.gnu.org/ml/gcc-patches/2004-09/msg02055.html that is available in gcc 4.1 or later only.
#if defined (__GNUC__) && _FORTIFY_SOURCE > 0 && !defined (__cplusplus) /* Security checking functions. */ #include <secure/_stdio.h> #endif
#if defined (__GNUC__) && _FORTIFY_SOURCE > 0 && !defined (__cplusplus) /* Security checking functions. */ #include <secure/_string.h> #endif
So, I were adding
diff -urN gcc-3.4.6-orig/include/ansidecl.h gcc-3.4.6/include/ansidecl.h --- gcc-3.4.6/include/ansidecl-orig.h 2006-02-06 15:06:55.000000000 +0100 +++ gcc-3.4.6/include/ansidecl.h 2009-05-01 13:31:36.000000000 +0200 @@ -321,4 +321,7 @@ #define __extension__ #endif
+/* avoid problems with memset and friends on Mac OS X */ +#define _FORTIFY_SOURCE 0 + #endif /* ansidecl.h */
I guess I could instead add a header patch to gcc. Something like:
--- stdio-orig.h 2009-05-02 09:29:48.000000000 +0200 +++ stdio.h 2009-05-02 10:04:41.000000000 +0200 @@ -426,7 +426,7 @@ #include <xlocale/_stdio.h> #endif /* _USE_EXTENDED_LOCALES_ */
-#if defined (__GNUC__) && _FORTIFY_SOURCE > 0 && !defined (__cplusplus) +#if defined (__GNUC__) && (__GNUC__ > 4 || (__GNUC__ == 4 && __GNUC_MINOR__ >= 1)) && _FORTIFY_SOURCE > 0 && !defined (__cplusplus) /* Security checking functions. */ #include <secure/_stdio.h> #endif
--- string-orig.h 2009-05-02 09:29:55.000000000 +0200 +++ string.h 2009-05-02 10:04:50.000000000 +0200 @@ -143,7 +143,7 @@ #include <xlocale/_string.h> #endif /* _USE_EXTENDED_LOCALES_ */
-#if defined (__GNUC__) && _FORTIFY_SOURCE > 0 && !defined (__cplusplus) +#if defined (__GNUC__) && (__GNUC__ > 4 || (__GNUC__ == 4 && __GNUC_MINOR__ >= 1)) && _FORTIFY_SOURCE > 0 && !defined (__cplusplus) /* Security checking functions. */ #include <secure/_string.h> #endif
Concerning adding a global define: have you tried passing modified CFLAGS to make?
I already tried, but it didn' work (using gcc-3.4.6) Neither does a configure --with-cppflags=. However, a make with CPPFLAGS="-D_FORTIFY_SOURCE=0" does do the job. Still the same problem as above, so I think it's unrelated. I will look further.
Regards,
Adriaan van Os
Waldek Hebisch wrote:
Adriaan van Os wrote: Concerning adding a global define: have you tried passing modified CFLAGS to make?
I already tried, but it didn' work (using gcc-3.4.6).
Thinking about it some further, my mistake was, I think, to use CCFLAGS instead of CFLAGS. I assume the first one is used ony during the first stage of the bootstrap (and that was exactly what went wrong).
Regards,
Adriaan van Os
-
Adriaan van Os -
Waldek Hebisch